Skip to content

fix: only pass non-nil span options - #38

Open
mweibel wants to merge 1 commit into
johnbellone:mainfrom
helio:fix-spanoptions
Open

fix: only pass non-nil span options#38
mweibel wants to merge 1 commit into
johnbellone:mainfrom
helio:fix-spanoptions

Conversation

@mweibel

@mweibel mweibel commented Jul 22, 2025

Copy link
Copy Markdown

fixes #37

@jqueuniet

Copy link
Copy Markdown

Hey, thanks for the patch, I tried it out and it does solve the panic issue, but I also noticed you used an options variable name which shadows an internal options type from this project (defined in options.go line 25). It would probably be for the best to change this variable name and avoid the naming conflict, even if it does not seem to cause any actual issue.

@mweibel

mweibel commented Aug 4, 2025

Copy link
Copy Markdown
Author

@jqueuniet ah yeah, good catch. Fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic due to UnaryServerInterceptor StartTransaction call with nil metadata

2 participants