Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to set user ID and GID #980

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

vladaurosh
Copy link
Contributor

Adding option to set user ID and GID running the application.

Related to #974 and #939

@jokob-sk
Copy link
Owner

thanks @vladaurosh

@jokob-sk jokob-sk merged commit 2ad7f02 into jokob-sk:main Jan 26, 2025
1 check passed
@jokob-sk
Copy link
Owner

can you also according to this update the docs ?

I imagine:

https://github.com/jokob-sk/NetAlertX/blob/main/dockerfiles/README.md
https://github.com/jokob-sk/NetAlertX/blob/main/docs/FILE_PERMISSIONS.md

also, should we set the defaults to the previous values? 102 or 101/82? So people won't have issues when updarading - or jsut skip this when values are not defined. Just worried about the support questions after upgrade.

@vladaurosh
Copy link
Contributor Author

vladaurosh commented Jan 26, 2025

That's actually great idea @jokob-sk

I'll update those. Latest stable version had 102/82 so I'll keep those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants