Skip to content

Conversation

@tetreum
Copy link

@tetreum tetreum commented Oct 23, 2018

Closes #2

@doowb
Copy link
Collaborator

doowb commented Oct 23, 2018

Thanks for the PR!

Since the test is failing, I want to get @jonschlinkert's input on this. With this change, on linux and mac any path passed in will be invalid. Since the description states that it checks windows paths, I think this makes sense. To test on a non-windows OS, I think the tests just need to take an options object with { windows: true } so that the logic is tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants