[5.3] BaseDatabaseModel should implement DatabaseAwareInterface

[heelc29]

Summary of Changes

Code in MVCFactory to set database to model is not working at the moment because BaseDatabaseModel do not implement DatabaseAwareInterface

joomla-cms/libraries/src/MVC/Factory/MVCFactory.php

Lines 170 to 177 in 2e81829

	if ($model instanceof DatabaseAwareInterface) {
	try {
	$model->setDatabase($this->getDatabase());
	} catch (DatabaseNotFoundException $e) {
	@trigger_error(\sprintf('Database must be set, this will not be caught anymore in 5.0.'), E_USER_DEPRECATED);
	$model->setDatabase(Factory::getContainer()->get(DatabaseInterface::class));
	}
	}

Deprecate DatabaseModelInterface and should removed together with libraries/src/MVC/Model/DatabaseAwareTrait.php so is J6.0 ok or should both removed with J7.0?

Testing Instructions

disable following code and open backend

joomla-cms/libraries/src/MVC/Model/BaseDatabaseModel.php

Lines 100 to 113 in 2e81829

	/**
	* @deprecated 4.3 will be Removed in 6.0
	* Database instance is injected through the setter function,
	* subclasses should not use the db instance in constructor anymore
	*/
	$db = \array_key_exists('dbo', $config) ? $config['dbo'] : Factory::getDbo();
	if ($db) {
	@trigger_error(\sprintf('Database is not available in constructor in 6.0.'), E_USER_DEPRECATED);
	$this->setDatabase($db);
	// Is needed, when models use the deprecated MVC DatabaseAwareTrait, as the trait is overriding the local functions
	$this->setDbo($db);
	}

Actual result BEFORE applying this Pull Request

500 error
if debug enabled:

Expected result AFTER applying this Pull Request

no 500 error when visit backend or frontend

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed
• Pull Request link for manual.joomla.org: TBD