-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] Re-ordering of tabs and fields in frontend #45081
base: 6.0-dev
Are you sure you want to change the base?
Conversation
I have tested this item ✅ successfully on 130af2a Tried it on a non multi-lingual site, turning on/off options in the Articles Options, then installed Multi-Lingual Sample Data, and did the same... turned on/off workflows and many other settings in Articles and all good/correct from a perspective of your PR... This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45081. |
@exlemor Same as in backend: |
@fgsw - sure (thanks), but why is that? i.e. all of the other fields look the same, are selectable etc except these - even if it is because they shouldn't be selectable it's odd visually no? |
I have tested this item ✅ successfully on 130af2a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45081. |
what is the point in anyone testing anything if test results that are different to those expected are marked as successful |
Hi @chmst , can you please update your result images to include the rendered < fieldset> and < legend> markup added by your code? or remove those tags to stay consistent with current images. |
Pull Request for Issue #44118 .
Replaces #44246 due to conflicts after rebasing
Summary of Changes
This PR re-arranges fields and tabs in frontend edit for articles.
It moves all options which are in the right sidbar of articles to a new tab "options"
It writes all fields which are in the publishing tab of the article into the publishing tab.
This removes the language tab and the metadata tab.
Testing Instructions
Compare the edit form for an article before and after the PR. Make sure that different user groups witrh different permissions have the same fields before and after the pr.
Switch on and off the show_publishing_data in articles options. on: publishing tab exists, off: no publishing data.
Check multilingual sites, if languages and associations are correct.
Actual result BEFORE applying this Pull Request
see #44118
Expected result AFTER applying this Pull Request
REMARK
It would be correct to have a new param for switching on and off the publishing tab.
Could be a follow-up PR.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed