Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3][cypress] avoid deprecated in api tags #45091

Open
wants to merge 3 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Mar 7, 2025

Pull Request for Issue # .

Summary of Changes

set default

Testing Instructions

npx cypress run --spec '.\tests\System\integration\api\com_tags\Tags.cy.js

Actual result BEFORE applying this Pull Request

PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in ..\530\administrator\components\com_tags\src\Model\TagsModel.php on line 299

Expected result AFTER applying this Pull Request

no more deprecated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon changed the title avoid deprecated [5.3][cypress] avoid deprecated in api tags Mar 7, 2025
@alikon alikon marked this pull request as ready for review March 7, 2025 19:33
@laoneo laoneo self-assigned this Mar 8, 2025
@muhme
Copy link
Contributor

muhme commented Mar 10, 2025

I have tested this item ✅ successfully on 49f2add

Tested with hacked JBT. Before applying the PR there a two deprecated warnings. After applying the PR the test spec still passed and there are no deprecated warnings.

Additional Note:

  • This depreaction was added in PHP 8.1
  • It doesn't need to enable Log Almost Everything in Joomla backend
  • It doesn't need to enable Log Deprecated API in Joomla backend
  • Windows Laragon shows the deprecation in php_errors.log file
  • Due logging with ¿SAPI (Server Application Programming Interface)? in macOS and Linux images in Docker the warning is not in the Apache error log or Docker log, as the other warnings
  • To see the deprecation, you have to configure php.ini or Apache in e.g. /etc/apache2/sites-enabled/000-default.conf file:
	php_flag log_errors on
        php_flag display_errors on
        php_value error_log /var/log/apache2/php_errors.log

And check by hand after the test:

docker exec jbt-53 cat /var/log/apache2/php_errors.log

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45091.

@laoneo
Copy link
Member

laoneo commented Mar 10, 2025

I have tested this item ✅ successfully on 49f2add

I'v manually removed the state in the code to see the error. After applying the patch, the error is gone.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45091.

@laoneo laoneo removed the PR-5.3-dev label Mar 10, 2025
@laoneo
Copy link
Member

laoneo commented Mar 10, 2025

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45091.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 10, 2025
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 9ad4735


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45091.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants