-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow email addresses with an underscore #45102
base: 5.2-dev
Are you sure you want to change the base?
Conversation
Testing Instructions: The 1st point should be: Plugins > Content-Email Cloaking This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45102. |
I have tested this item ✅ successfully on 74ec6b1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45102. |
I have tested this item ✅ successfully on 74ec6b1 |
I have tested this item ✅ successfully on 74ec6b1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45102. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45102. |
@ChristineWk @BennoMath @dautrich Have you also tested that an email address without underscore still works? Am asking because that part is missing in the testing instructions. But it should always be tested that nothing is broken by a fix, not only that the issue is fixed. This just in general, I don’t expect any issues. |
I just checked it with activated PR. It's OK. |
@ChristineWk Thanks for checking. That’s sufficient for me. |
Thank you everyone for testing this PR. |
@richard67 I also successfully checked with an email address without an underscore, with the PR code applied. |
@richard67 Yes, successfully tested also with an email address without underscore. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45102. |
Pull Request for Issue #45100 .
Summary of Changes
Modify the $searchEmail pattern by adding the underscore character to the character class where it's currently matching letters, numbers, and special characters like periods, apostrophes, hyphens, and plus signs.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed