[5.2] Correct display of user profile

[AkameOuO]

Pull Request for Issue #45079 .

Summary of Changes

It tries to check if keys are registered in HTMLHelper. But keys are not registered until the first call to HTMLHelper::(). Therefore, I call HTMLHelper::() without checking if keys are registered and use a catch block when the key is invalid.

And add two methods in Joomla\Component\Users\Administrator\Service\HTML\Users for colorScheme and allowTourAutoStart.

Testing Instructions

Reproduce the steps as described in the original issue.

Actual result BEFORE applying this Pull Request

Display raw values from database.

Expected result AFTER applying this Pull Request

Display sanitized texts.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[fgsw]

I have tested this item ✅ successfully on 8287cc7

Before Pull Request

After Pull Request

Using - Use Default - show with and without PR the same result:

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45107.}

[dautrich]

I have tested this item ✅ successfully on 8287cc7

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45107.}

[alikon]

rtc

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45107.}

[richard67]

The HTMLHelper::_ throws InvalidArgumentException at a few places, so here you catch all of them, not only the one you want to catch. So you will hide other errors, too, with that code.

[AkameOuO]

Would it be better if I revert this part and manually register the function with HTMLHelper before it is called?

[richard67]

Same as my previous comment.

[richard67]

Adding the "RMDQ" (release managers decision queue) label as I have some doubts if this fix is good as it is.

[bembelimen]

Hello @AkameOuO
thanks for the PR. We discussed it in the Maintainer-Team and we agree, that we should add the two methods to the Users file. But we don't want to change the component tmpl files. So could you please revert that changes?
Also when checking I don't see the Atum-Parameter translated (still "10" for me)

[richard67]

Back to pending due to requested changes. See previous comment.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45107.}

[AkameOuO]

@bembelimen

It still needs other patches for fixing the issue if reverting changes to tmpl files. I will try the method in this comment #45107 (comment).

before ec40c91:

after ec40c91: