Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3]allowTourAutoStart in user profile #45109

Open
wants to merge 2 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Mar 11, 2025

Pull Request for Issue # .

Summary of Changes

The param allowTourAutoStart is an admin interface only param. It makes no sense to display the field in the user profile page nor in the edit profile page.

This PR moves it to the frontend_admin.xml file with the other admin interface only params

Testing Instructions

Create a menu item to display the user profile
Login as a registered user and check the profile
Login as a registered user and edit the profile
Login as an administrator user and check the profile
Login as an administrator user and edit the profile

Actual result BEFORE applying this Pull Request

Registered user displays the params for Auto starting tours
Administrator user displays the params for Auto starting tours
image
image

Expected result AFTER applying this Pull Request

Registered user does not display the params for Auto starting tours
Administrator user displays the params for Auto starting tours

image
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla joomla deleted a comment from obelick88889 Mar 11, 2025
@joomla joomla deleted a comment from fgsw Mar 11, 2025
@fgsw
Copy link

fgsw commented Mar 12, 2025

I have tested this item ✅ successfully on 9db5949

Without pull request

01

With pull request

02

Test by using a user of user group "Registered" and custom update server of prebuilt packages.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45109.

@QuyTon
Copy link
Contributor

QuyTon commented Mar 12, 2025

I have tested this item ✅ successfully on 9db5949


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45109.

@QuyTon
Copy link
Contributor

QuyTon commented Mar 12, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45109.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants