Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] System test in media manager to prevent a rename #45115

Open
wants to merge 2 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Mar 12, 2025

Summary of Changes

Pull request to actually check if an image can be renamed to a different one with a PHP file extension.

See https://developer.joomla.org/security-centre/961-20250301-core-malicious-file-uploads-via-media-managere-malicious-file-uploads-via-media-manager.html for more details.

@SniperSister
Copy link
Contributor

I have tested this item ✅ successfully on c2f0fc4

Perfect, thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45115.

@richard67
Copy link
Member

I have tested this item ✅ successfully on c2f0fc4

Verified in drone logs that the new system test was run, and reviewed that it tests the recent security fix.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45115.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45115.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-5.3-dev RTC This Pull Request is Ready To Commit Unit/System Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants