Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Calendar: Highlight selected day in frontend. #45119

Open
wants to merge 4 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

krishnaGandhi11
Copy link

This is a reopened version of PR #45096

I am unable to reopen #45096 because of technical reasons, sorry ;)

Testing Instructions

-Open an article and try to set a publishing date (this opens the calendar).
-Select a date and check if it gets highlighted properly.
-Test on multiple browsers (Chrome, Firefox, Edge, Safari).

Actual result BEFORE applying this Pull Request

-The selected date in the calendar was not highlighted in the frontend.
-The backend calendar worked correctly, but the frontend did not.
420588362-9f287c2e-0b1c-48ff-816f-1deecb2d1a6b

Expected result AFTER applying this Pull Request

-The selected date should now be properly highlighted in the frontend calendar, just like in the backend.

video-sr.mp4

krishnaGandhi11
krishnaGandhi11 commented 4 days ago
Pull Request for Issue #45082

Summary of Changes :
-Fixed the issue where the selected day in the calendar was not highlighted in the frontend.
-Applied correct styling to match the backend calendar appearance.

Testing Instructions :
-Open an article and try to set a publishing date (this opens the calendar).
-Select a date and check if it gets highlighted properly.
-Test on multiple browsers (Chrome, Firefox, Edge, Safari).

Actual result BEFORE applying this Pull Request :
-The selected date in the calendar was not highlighted in the frontend.
-The backend calendar worked correctly, but the frontend did not.
Before

Expected result AFTER applying this Pull Request :
-The selected date should now be properly highlighted in the frontend calendar, just like in the backend.

Fixed.mp4
Fixes #45082

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@krishnaGandhi11 krishnaGandhi11 requested a review from chmst as a code owner March 12, 2025 21:53
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Mar 12, 2025
@exlemor
Copy link

exlemor commented Mar 12, 2025

I have tested this item ✅ successfully on fa62ec3

I have tested this successfully. Thanks Krishna.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45119.

@brianteeman
Copy link
Contributor

For all the reasons I have already explained this PR is wrong AND you have committed unrelated files

@richard67
Copy link
Member

AND you have committed unrelated files

@brianteeman It's only one file, the package-lock.json, and the only change in that file is the Joomla version change to 5.2.6, which happens as a result of npm ci or npm install. It would not do harm to have it in this PR, but of course it wouldbe cleaner to keep that separate.

@krishnaGandhi11 Could you revert the change in the package-lock.json file? Thanks in advance.

@joomla-cms-bot joomla-cms-bot removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Mar 13, 2025
@krishnaGandhi11
Copy link
Author

For all the reasons I have already explained this PR is wrong AND you have committed unrelated files

As I mentioned earlier, my last PR got deleted, so I raised the same one again to continue working on it further.

@krishnaGandhi11
Copy link
Author

AND you have committed unrelated files

@brianteeman It's only one file, the package-lock.json, and the only change in that file is the Joomla version change to 5.2.6, which happens as a result of npm ci or npm install. It would not do harm to have it in this PR, but of course it wouldbe cleaner to keep that separate.

@krishnaGandhi11 Could you revert the change in the package-lock.json file? Thanks in advance.

@richard67 Thanks for pointing that out! I've now reverted the changes in package-lock.json to keep the PR clean. Appreciate your guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.2] Calendar in Frontend - missing bs-variables
5 participants