Skip to content

Fix(typecheck): resolve PR1219 regressions + fix existing main TS errors#10

Merged
joonsoome merged 3 commits intomainfrom
fix/pr1219-typecheck
Feb 6, 2026
Merged

Fix(typecheck): resolve PR1219 regressions + fix existing main TS errors#10
joonsoome merged 3 commits intomainfrom
fix/pr1219-typecheck

Conversation

@joonsoome
Copy link
Copy Markdown
Owner

@joonsoome joonsoome commented Feb 6, 2026

Issues

  1. Regressions introduced by PR #1219 (3 type error for awaiting #1200), and
  2. Pre-existing typecheck failures already present on upstream/main (6 issues)
    The branch is rebased on top of upstream/main, and both local checks now pass.

Branch : fix/pr1219-typecheck
Commit : 0c302584fix: make typecheck pass

Verification

  • pnpm check → 0 errors
  • pnpm -s exec tsc -p tsconfig.json --noEmit → exit 0

1) PR kwaroran#1219 regressions fixed (new breakages introduced by the PR)

While reproducing pnpm check on pr-1219, I found 9 errors total:

  • 6 already exist on upstream/main (baseline)
  • 3 are introduced by PR fix: Hyper Memory V3 'ot' & 'startsWith' error Bug Resolve kwaroran/Risuai#1219 (regressions)
    These PR-specific breakages are now fixed:
  • Missing module: src/ts/util/inlayTokens
    • hypav3.ts imported src/ts/util/inlayTokens, but the module did not exist, causing typecheck to fail.
    • Fix : added/implemented the missing module export via inlayTokens.ts and introduced inlayTokenRegex (resolves TS2307).
  • New settings keys without Database schema/defaults
    • advancedSettingsData.ts introduced bindKey: 'checkCorruption', but Database had no such field/default.
    • accessibilitySettingsData.ts introduced toggleConfirmRecommendedPreset, also missing from Database.
    • Fix: added both keys to the Database type and ensured defaults are set in database.svelte.ts (setDatabase() defaults to false).

2) Pre-existing upstream/main typecheck failures fixed (not introduced by PR kwaroran#1219)

These issues were already failing on main, and are included here to keep the tree typecheck-clean:

  • plugins.svelte.ts
    • Removed window.trustedTypes typing error (with required unknown casting)
    • Removed @ts-expect-error
    • Forced createRealScript() return type to string
  • IconButton.svelte
    • Re-destructured id from $props() to remove the id={id} TS error\
  • RealmFrame.svelte
    • Reverted asBuffer(...buffer) back to the #1200 approach using toArrayBuffer(Uint8Array) to fix ArrayBuffer typing mismatch
  • hypav3.ts
    • Kept sanitization behavior: replace {{inlay...}} tokens with [Image] in summaries

Note: postcss-selector-parser TS2307

The postcss-selector-parser TS2307 was caused by an out-of-date local node_modules.
After running pnpm install --frozen-lockfile, the correct install/linking resolved it (no shim files added).

@joonsoome joonsoome merged commit a2faafb into main Feb 6, 2026
4 checks passed
@joonsoome joonsoome deleted the fix/pr1219-typecheck branch February 21, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant