Fix(typecheck): resolve PR1219 regressions + fix existing main TS errors#10
Merged
Fix(typecheck): resolve PR1219 regressions + fix existing main TS errors#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
The branch is rebased on top of upstream/main, and both local checks now pass.
Branch :
fix/pr1219-typecheckCommit :
0c302584—fix: make typecheck passVerification
1) PR kwaroran#1219 regressions fixed (new breakages introduced by the PR)
While reproducing pnpm check on pr-1219, I found 9 errors total:
These PR-specific breakages are now fixed:
src/ts/util/inlayTokenshypav3.tsimportedsrc/ts/util/inlayTokens, but the module did not exist, causing typecheck to fail.inlayTokens.tsand introducedinlayTokenRegex(resolvesTS2307).advancedSettingsData.tsintroducedbindKey: 'checkCorruption', butDatabasehad no such field/default.accessibilitySettingsData.tsintroducedtoggleConfirmRecommendedPreset, also missing fromDatabase.Databasetype and ensured defaults are set indatabase.svelte.ts(setDatabase()defaults tofalse).2) Pre-existing
upstream/maintypecheck failures fixed (not introduced by PR kwaroran#1219)These issues were already failing on main, and are included here to keep the tree typecheck-clean:
plugins.svelte.tswindow.trustedTypestyping error (with requiredunknowncasting)@ts-expect-errorcreateRealScript()return type tostringIconButton.svelteidfrom$props()to remove theid={id}TS error\asBuffer(...buffer)back to the #1200 approach usingtoArrayBuffer(Uint8Array)to fixArrayBuffertyping mismatchhypav3.ts{{inlay...}}tokens with[Image]in summariesNote: postcss-selector-parser TS2307
The
postcss-selector-parserTS2307was caused by an out-of-date localnode_modules.After running
pnpm install --frozen-lockfile, the correct install/linking resolved it (no shim files added).