sort discovered files by date modified #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for people doing bulk import it's important to know which files are going to be processed. Ultimately a better patch is to pass how to sort (date modified, alphabetically, none - in this case the user should rely on the fact that Dir.glob behaves differently across platforms) and logstash e.g. the file plugin could have option "sort". for now I think it's important users KNOW that files are sorted by date modified or alternatively alphabetically: ```globbed_dirs = Dir.glob(path).sort```
sort discovered files by date modified
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for people doing bulk import it's important to know which files are going to be processed.
Ultimately a better patch is to pass how to sort (date modified, alphabetically, none - in this case the user should rely on the fact that Dir.glob behaves differently across platforms) and logstash e.g. the file plugin could have option "sort".
for now (if the pull request is accepted) I think it's enough for users to KNOW that files are sorted by date modified or alternatively alphabetically:
globbed_dirs = Dir.glob(path).sort