Skip to content

Conversation

@Gekctek
Copy link

@Gekctek Gekctek commented Mar 4, 2024

Adding support for using local development canisters vs mainnet

@Gekctek
Copy link
Author

Gekctek commented Mar 4, 2024

Hey @jorgenbuilder
I was just dabbling with making the your extension work with localhost
I figured I would throw this up here to see if you have any interest in adding it, otherwise ill just keep it in my fork

@jorgenbuilder
Copy link
Owner

Hey Ethan, this has actually been on my radar for a long time. I'm excited to review and get this merged if it's ready to go.

@Gekctek
Copy link
Author

Gekctek commented Mar 4, 2024

It works, but im still testing it out for my canister development, so we can hold off from merging
Be curious to your review insights, you know the code base best so not sure if some of my patterns fit what you are looking for

@jorgenbuilder
Copy link
Owner

How's this looking on your end? I'll wait until you give your stamp of approval before diving in, but very excited to make this happen :)

@Gekctek
Copy link
Author

Gekctek commented Mar 6, 2024

Everything is still working on my end, so you can go ahead and take a look

@jorgenbuilder
Copy link
Owner

Had a quick look today. Not a fan of the amount of reorganization, makes the diff harder for me to follow 😅. I might attempt to pick out the functional pieces this weekend.

@Gekctek
Copy link
Author

Gekctek commented Mar 8, 2024

That's fair. Wasn't sure how to tackle it because i had to detect the local vs not by the url (which has its own issues) and the current model initialized everything as globals no matter the context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants