fix: Handle aborted signals by making pending promises always return the latest value - #20
Merged
Merged
Conversation
Aliath
approved these changes
May 31, 2026
| // computation. | ||
| if (signal.aborted) { | ||
| return undefined as T; | ||
| return getLatest(); |
iwoplaza
force-pushed
the
fix/handle-aborted-signals
branch
from
May 31, 2026 09:48
297df9e to
07f79ec
Compare
Collaborator
Author
|
@Aliath I added one more commit that handles old computations that never resolve, with additional tests that cover those cases |
Aliath
approved these changes
May 31, 2026
iwoplaza
force-pushed
the
fix/handle-aborted-signals
branch
from
May 31, 2026 19:00
ea1e5fd to
4568c2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.