This repository was archived by the owner on Jul 23, 2019. It is now read-only.
Fix issue 551 - #553
Open
anamauad wants to merge 3 commits into
Open
Conversation
…oUnicode was updated to search for the shortname in parent emoji. Tests added for shortnameToUnicode and shortnameToImage.
Author
|
There is a problem with the build in CI tool: UNMET PEER DEPENDENCY grunt@1.0.1 Maybe the npm needs to be upgraded, according to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #551 and added test cases for it.
Function
shortnameToImagewas searching for:+1:instead of:\\+1:inns.shortnames.Function
shortnameToUnicodewas searching for:+1:in emojiList, but:+1:is an alternate shortname of:thumbsup:. It was updated to search inns.shortnamesand then searched for in parents.