Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of the match merging after the matching is done #1447

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Improve performance of the match merging after the matching is done #1447

merged 1 commit into from
Jan 10, 2024

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Dec 15, 2023 •
edited
Loading

Partially addresses #1430:

  • Improve the performance of the neighbor calculation by avoiding sorting
  • Improve the performance of the match filtering by using streams instead of removal lists

Brings around 10 to 30% better performance for GST + merging for datasets of large programs depending on paramterization.

@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Dec 15, 2023
@tsaglam tsaglam linked an issue Dec 15, 2023 that may be closed by this pull request
Match merging has performance issues with submission sets of larger programs #1430
Open
@tsaglam tsaglam removed a link to an issue Dec 15, 2023
Match merging has performance issues with submission sets of larger programs #1430
Open
@tsaglam tsaglam marked this pull request as ready for review December 15, 2023 13:07
@tsaglam tsaglam merged commit e09be8c into develop Jan 10, 2024
12 checks passed
@tsaglam tsaglam deleted the fix/merging-perf branch January 10, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoOfTwelve TwoOfTwelve Awaiting requested review from TwoOfTwelve

Assignees
No one assigned
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsaglam