Fix c23 build error from nographics.h - #240
Merged
Merged
Conversation
c23 no longer allows functions with no prototype, and treats an empty parameter list as (void). This broke some macro definitions where functions with arguments were aliased to nop, a function without args. This commit updates the aliases to function-like macros, and ensures nop receives 0 arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#239
c23 no longer allows functions with no prototype, and treats an empty parameter list as (void). This broke some macro definitions where functions with arguments were aliased to
nop, a function without args.This PR updates the aliases to function-like macros, and ensures nop receives 0 arguments.
Testing
This PR addresses the nographics path.
"too many arguments to function call, expected 0, have 4" error is gone