Minor fixes for issues identified in Geant4 by Coverity #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmadsen
approved these changes
Jul 16, 2024
|
Hi @jrmadsen, looking at the CI failures, I don't think they're related to the changes here but let me know if not! |
|
@drbenmorgan If I had to guess, the failures are because the PTL/.github/workflows/macos-ci.yml Line 22 in f892a93 |
jrmadsen
force-pushed
the
coverity-fixes
branch
2 times, most recently
from
a1759a1
to
c71ab36
Compare
|
@drbenmorgan I moved the CI fixes to #50 (along with some changes identified by clang-tidy) and rebased your branch onto the main branch. Will merge as soon as CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of tiny fixes that Geant4's Coverity analysis picked up in PTL. Nothing major, but good to have integrated even if we patch locally.