Strip off ANSI colored maven output from deps lines #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated some time ago in favor of jars/installer.
This extra output got included in the filename and breaks installation of jars on platforms where the output gets included. This includes at least Linux, but I have been unable to reproduce on MacOS so far. This is a stopgap until I can figure out why this output is happening and fully disable it. The regexp matching in this method could also be improved to avoid breaking on future format changes. Fixes jruby#92. See also jruby/jruby#8606.
headius
force-pushed
the
strip_ansi_garbage
branch
from
b3a0fba to
f95d32c
Compare
headius
added a commit
to headius/jruby
that referenced
this pull request
Feb 6, 2025
headius
added a commit
to jruby/jruby
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extra output got included in the filename and breaks installation of jars on platforms where the output gets included. This includes at least Linux, but I have been unable to reproduce on MacOS so far. This is a stopgap until I can figure out why this output is happening and fully disable it.
The regexp matching in this method could also be improved to avoid breaking on future format changes.
Fixes #92.
See also jruby/jruby#8606.