-
-
Notifications
You must be signed in to change notification settings - Fork 4k
opencc.js.org #10502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencc.js.org #10502
Conversation
d79ad97 to
0bb6f93
Compare
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 While I appreicate that the page is a demo of the NPM package, at present unless I'm missing something, it is just that, only a demo -- just a webpage that happens to be built with JavaScript as is every other page on the web, with nothing about it being specifically useful to other JavaScript developers.
Could I suggest updating the page to include explicit documentation for the NPM package, to guide other JavaScript developers on how they could use it for their own projects?
|
Thank you for the feedback! That makes total sense. I’ve updated the homepage so that it now serves as the landing page for the OpenCC WASM library, rather than just a standalone demo. It currently includes:
I plan to continue expanding the documentation on both the homepage and the GitHub repository as the API stabilizes and additional usage scenarios are documented. The page should now more clearly reflect how the library is intended to be used by JavaScript developers. |
|
I've already added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain. FYI: https://github.com/js-org/js.org/wiki/3rd-party-hosts
I'll merge after we have "contact". Please keep this PR open. |
|
The Attach To Domain API on Workers has a
I'll move the site to a CF Pages. |
|
You have to update the target in the cname list to match you new hosting.
|
0bb6f93 to
f7a3012
Compare
This website is a landing page for [opencc-wasm](https://npmjs.com/package/opencc-wasm), a WASM library based on OpenCC. Website code is available from https://github.com/frankslin/opencc-wasm-demo-site/ and deployed to a CloudFlare Page. Library code is available from https://github.com/frankslin/OpenCC/wasm-lib/ .
f7a3012 to
bf4c4c2
Compare
|
The branch is updated and rebased. |
|
@frankslin I've just made the change in JS.ORGs zonefile but still get the Error 1014. Maybe it needs time to propagate or you need to re-set the CNAME via the api endpoint. |
|
It works now! https://opencc.js.org/ |
|
Welcome https://opencc.js.org |
This website is a landing page for NPM package opencc-wasm, a WASM library based on OpenCC, an open-sourced Chinese conversion tool.
Website code is available from https://github.com/frankslin/opencc-wasm-demo-site/ and deployed to a CloudFlare Page.
The WASM library code is available from https://github.com/frankslin/OpenCC/tree/master/wasm-lib.