This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Fix TestAgentIntrospect: TmuxAvailable should reflect agent type#289
Merged
jsell-rh merged 1 commit intojsell-rh:mainfrom Mar 23, 2026
Merged
Conversation
… backend availability The TmuxAvailable field in the introspect response should indicate whether the agent's registration type allows session-based lifecycle management (spawn/stop/restart), not whether tmux is currently installed on the system. For agents without an explicit registration or with session-compatible types (tmux/ambient/""), TmuxAvailable should be true regardless of whether the backend is actually available at runtime. This fixes the test failure where unregistered agents would incorrectly report TmuxAvailable=false in environments without tmux installed. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmux_availablefield in introspect responsesProblem
The test was failing because
TmuxAvailablewas computed as:In test environments without tmux installed,
backend.Available()returnsfalse, causing the test to fail even though the agent type (unregistered/default) should be session-compatible.Solution
Removed the
backend.Available()check. The field now only checks the agent's registration type:Test Results
Rationale
TmuxAvailablerepresents a property of the agent's configuration (whether it can be managed via session lifecycle), not the runtime environment (whether tmux is installed). This separation is important because:agent_typeare session-compatible by default🤖 Generated with Claude Code