Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md for better guidance for new contributors #1259

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update CONTRIBUTING.md for better guidance for new contributors #1259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b3d763
Update CONTRIBUTING.md to better guide new contributors
benjagm Jan 7, 2025
cbc0f51
add auggestion.
benjagm Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ For more details on our testing setup and how to run tests, please refer to the

### ⌨️ Pull requests

We welcome pull requests for editorial suggestions and resolving open issues.
We welcome pull requests for editorial suggestions and resolving open issues.

If your pull request addresses a specific issue, please reference this issue in your pull request description using a [supported descriptor](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword). This helps automatically link and close the issue when the pull request is merged.

Expand All @@ -109,6 +109,11 @@ We strongly encourage linking every pull request to an existing issue. If no cor
- If the issue is several years old, verify its relevance by asking in the comments.
- Ensure the discussion within the issue has led to a clear, actionable decision.

Before submitting a PR, please make sure:
- The PR has a linked issue.
- The related Issue has already completed the [triage process](https://github.com/json-schema-org/.github/blob/main/TRIAGE.md) and has the label `Status Accepted` or `Status Available`.
- You are assigned to work on this issue by a Maintainer or the Triage Team. Submitting a PR without getting assigned to the Issue may lead to the PR to get closed.

Generally, pull requests should be made to the `main` branch.

Most PRs, will be left open for a minimum of 14 days. Minor fixes may be merged more quickly once approved by a project member.
Expand Down
Loading