-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve Enum documentation #1312
base: main
Are you sure you want to change the base?
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
@benjagm @valeriahhdez review this PR |
@techmannih pls. attach some screenshots and screencasts showing your changes |
@DhairyaMajmudar sure, 20250201090654.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of replacing one example with another, I suggest adding your example to the document. Please provide an introductory statement to your example.
@@ -18,16 +18,21 @@ The following is an example for validating street light colors: | |||
```json | |||
// props { "isSchema": true } | |||
{ | |||
"enum": ["red", "amber", "green"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we should keep this example and add yours to the document instead of replacing examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @valeriahhdez , I’m trying to improve the format for the previous examples to make them similar to the other doc. I’m not replacing the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just my suggestion I left the final decision to the author
@@ -18,16 +18,21 @@ The following is an example for validating street light colors: | |||
```json | |||
// props { "isSchema": true } | |||
{ | |||
"enum": ["red", "amber", "green"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just my suggestion I left the final decision to the author
What kind of change does this PR introduce?
improve Enum documentation
Issue Number: