-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed mobile blog card #1319
base: main
Are you sure you want to change the base?
fixed mobile blog card #1319
Conversation
Hi @DhairyaMajmudar any approval of what design should I go for? |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 387 387
Branches 103 103
=========================================
Hits 387 387 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cbum-dev pls. don't open PR without issues assign and follow our community guidelines. |
Hi @DhairyaMajmudar, This PR is actually a fix for issue #1280. Initially, I made a typo, which I later corrected, but the update wasn't reflected here. Since #1280 was assigned to me, this PR is directly related to that issue. |
Your PR description to pointing to issue #1277 pls. enter correct issue number. |
Done, and look at this also. |
I'll fix it. |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
![image](https://private-user-images.githubusercontent.com/110410015/404301689-f7673411-3819-4452-af11-a2893aea1a4a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTE2MTMsIm5iZiI6MTczOTU5MTMxMywicGF0aCI6Ii8xMTA0MTAwMTUvNDA0MzAxNjg5LWY3NjczNDExLTM4MTktNDQ1Mi1hZjExLWEyODkzYWVhMWE0YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwMzQ4MzNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kN2Q1OGZmNTFjNWIwZDU5NTQwNTVjOGE2YThkMmFhOTc0ODE3Mjg2MTJjYTYxNDM5MDg5ZmE1YTU0YWFlMTQ1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.t1mR0AIRc9Sc9mN-k_maZZbt6KVpbq7amrHXXmyHda8)
Earlier-
Now-
![image](https://private-user-images.githubusercontent.com/110410015/404300529-53b69482-9689-4150-b160-5fdc7a0b23b4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTE2MTMsIm5iZiI6MTczOTU5MTMxMywicGF0aCI6Ii8xMTA0MTAwMTUvNDA0MzAwNTI5LTUzYjY5NDgyLTk2ODktNDE1MC1iMTYwLTVmZGM3YTBiMjNiNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwMzQ4MzNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lOWYyMjc4YzQ3NDdhNDk0ZDI5MzYxMDU0ZGE2Njk4MGM4OTZmY2E5OTJiZjBhYjQwOGE5ZjA5OTRiOWZkOTJjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.siqoJwRXaZw_pRSLcb9qP94W2tsZB4Ivy38uX2Zi8WY)
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?