-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]-added hover effect and 'Read More' to blog cards #1350
base: main
Are you sure you want to change the base?
[Feat]-added hover effect and 'Read More' to blog cards #1350
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1350 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MadhavDhatrak if you check we're getting such background effect while hovering the headlines
Screencast.from.2025-01-31.23-47-18.webm
Pls. fix them its not required
styles/globals.css
Outdated
/* Add smooth transitions for dark mode */ | ||
.dark .group:hover { | ||
background: rgba(255, 255, 255, 0.05); | ||
} | ||
|
||
/* Enhance card interactions */ | ||
.group { | ||
transition: all 0.3s ease; | ||
} | ||
|
||
.group:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls. remove comments too
Hey @DhairyaMajmudar As you requested I have made the following changes:
A video demo is attached below: screen-recording-2025-02-02-103151_9cmM0F1b.mp4Please review the changes and let me know if any further modifications are needed. |
This is looking mostly great but it is missing the last changes made on main. Can you please update from main and fix the merge conflicts to check if we can merge it? |
f081829
to
c34484f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awsm work, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjagm Some code for the "Read More" button may have been removed or overwritten during merge conflict resolution causing it to not appear in some cases No worries, I'll update it again! |
c46306b
to
ca6d9ca
Compare
Hi @MadhavDhatrak! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: breaking changes information Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Hi @MadhavDhatrak! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: breaking changes information Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Hi @MadhavDhatrak! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: breaking changes information Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Hi @MadhavDhatrak! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: breaking changes information Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
@benjagm @DhairyaMajmudar |
This PR needs to include the changes added with #1477 to have all the blog images with the same size. |
What kind of change does this PR introduce?
Feature Addition- Add hover and Read More to blog cards
Issue Number:
Screenshots/videos:
screen-recording-2025-01-21-205322_lsZboQTR.mp4
If relevant, did you update the documentation?
No
Summary
Added new UI enhancements to improve blog post interaction and readability:
Does this PR introduce a breaking change?
No this is just a UI enhancement that doesn't affect functionality