Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arrow svg compatible with dark mode and responsiveness of text #1468

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Karan-Palan
Copy link
Contributor

What kind of change does this PR introduce?

  • Improved the color contrast of arrows in "Go Back" and "Up Next" buttons in dark mode. (used #2563EB for Arrow svg i.e color used for hyperlinks across the website)
  • Ensured consistent vertical stacking and alignment of text and arrows across screen sizes.

Issue Number:

Screenshots/videos:

Screenshot from 2025-03-06 04-55-00

If relevant, did you update the documentation?

No

Summary

Does this PR introduce a breaking change?

@Karan-Palan Karan-Palan requested a review from a team as a code owner March 5, 2025 23:33
Copy link

github-actions bot commented Mar 5, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 32c8a11

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (60f2d6a) to head (32c8a11).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1468   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Karan-Palan
Copy link
Contributor Author

Based on #1292 (comment), made these changes:

Screencast.from.2025-03-16.14-30-04.webm

@DhairyaMajmudar , ptal

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Low Contrast on Arrows in "Go Back" and "Up Next" Buttons in Dark mode and responsiveness issue
2 participants