-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced category filtering #1507
Enhanced category filtering #1507
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idanidan29 pls. resolve the merge conflicts from your PR.
pages/blog/index.page.tsx
Outdated
@@ -1,3 +1,4 @@ | |||
/* eslint-disable indent */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't bypass eslint by disable comments
pages/blog/index.page.tsx
Outdated
@@ -46,6 +49,7 @@ export async function getStaticProps({ query }: { query: any }) { | |||
|
|||
await generateRssFeed(blogPosts); | |||
|
|||
// Filtering based on query parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comments
d705f6c
to
ea04243
Compare
…idan29/website into Enhanced-category-filtering
This reverts commit d705f6c.
This reverts commit af4a141.
Thanks for the feedback, @DhairyaMajmudar! I'm having a hard time resolving the conflicts, and the codebase on the branch is a bit outdated. I'll keep working on this in a new branch and open a new PR with your adjustments once it's done |
What kind of change does this PR introduce?
Feature – This PR allows blog posts to belong to multiple categories instead of just one. and improve the filtering to filter more than one category
Issue Number:
Screenshots/videos:
*I added the category to the blog only for the example picture and did not actually change the blog category.
Summary
Blog posts now support multiple categories by framing them like this in the blog file:
This enhancement improves content organization, filtering functionality, and provides greater flexibility for authors.
Does this PR introduce a breaking change?
no