Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: v0 infinite scrolling #1510

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Nabhag8848
Copy link

@Nabhag8848 Nabhag8848 commented Mar 12, 2025

What kind of change does this PR introduce?

  • Infinite Scrolling

Issue Number:

Screenshots/videos:

https://drive.google.com/file/d/1CFgrQW9PksBX7Y5RT4DX51czhqSAYDO9/view?usp=sharing

Summary

  • Blog post getting load all at once, now its loading as scroll

Does this PR introduce a breaking change?

  • In Discussion

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (219521e) to head (d291d34).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1510   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Nabhag8848
Copy link
Author

Nabhag8848 commented Mar 12, 2025

@DhairyaMajmudar @benjagm few questions:

  • Currently we have static export and that is avoiding us to have an api endpoint ? Is this intentional.

to have endpoint we need to remove 'output': 'export'. reference - https://nextjs.org/docs/pages/building-your-application/deploying/static-exports

  • I have used react-intersection-observer, is this fine ? was there any other expectation ?

Still I need to refine but this is v0 which works.

looking for suggestions.

@DhairyaMajmudar
Copy link
Member

Thanks @Nabhag8848 for the PR, regarding your questions

  1. Yes 'output': 'export' is kept intentionally as we need to keep the website client side, which further saves the server costs.
  2. Instead of introducing /api directory you can follow https://nextjs.org/docs/pages/building-your-application/optimizing/lazy-loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Implement Infinite Scrolling (Lazy Loading)
2 participants