Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed]: Navbar Active State Not Highlighting Docs and Specification related pages #1537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KajalMishra-29
Copy link

@KajalMishra-29 KajalMishra-29 commented Mar 17, 2025

What kind of change does this PR introduce?

  • Bugfix for Navbar Active State Not Highlighting Docs and Specification on related pages

Issue Number:

Screenshots
image
image
image

If relevant, did you update the documentation?
N/A

Summary

  • This PR fixes an issue where the navbar links for "Docs" and "Specification" were not highlighted as active when visiting related subpages.
  • Previously, the isActive condition only checked if the router.asPath started with /docs or /specification, which did not account for related subpages like /overview/... or /draft/....
    Changes Made
  • Updated the isActiveNav condition to include related subpaths:
    • Docs: Now considers /overview/... as part of the "Docs" section.
    • Specification: Now includes /draft/... as part of the "Specification" section.

Does this PR introduce a breaking change?
No

@KajalMishra-29 KajalMishra-29 requested a review from a team as a code owner March 17, 2025 05:48
Copy link

Hi @KajalMishra-29! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link

github-actions bot commented Mar 17, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview a481beb

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72883db) to head (a481beb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1537   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Hi @KajalMishra-29! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

1 similar comment
Copy link

Hi @KajalMishra-29! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

@KajalMishra-29
Copy link
Author

@benjagm
please review this PR.

@cbum-dev
Copy link
Contributor

Hi @KajalMishra-29 this issue was assigned to me. Please read the community guidelines.

@KajalMishra-29
Copy link
Author

Hi @cbum-dev, I apologize for the confusion—I didn't realize the issue was assigned to you. I went ahead and resolved it, but if there's anything you'd like me to adjust or review, just let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants