Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo in Environment Variables Setup Section #867

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

KaranDasA1
Copy link
Contributor

@KaranDasA1 KaranDasA1 commented Aug 15, 2024

closes #866

This pull request corrects a minor typo in the documentation for setting up environment variables. The term "Enviroment" has been corrected to "Environment" for clarity and accuracy. This fix ensures that the documentation is clear and professional.

@KaranDasA1 KaranDasA1 requested a review from a team as a code owner August 15, 2024 18:43
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Aug 15, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 3a2fb55

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cc3ce3e) to head (3a2fb55).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #867   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           20        20           
  Branches        12        12           
=========================================
  Hits            20        20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this @KaranDasA1 !!

@benjagm benjagm merged commit d6a6139 into json-schema-org:main Aug 16, 2024
11 checks passed
Copy link

Congratulations, @KaranDasA1 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📝 Docs]: Spelling and Grammar Errors in README
3 participants