fix $toMillis() with more than 3 digit fractional seconds#782
Merged
mattbaileyuk merged 1 commit intomasterfrom Apr 30, 2026
Merged
fix $toMillis() with more than 3 digit fractional seconds#782mattbaileyuk merged 1 commit intomasterfrom
mattbaileyuk merged 1 commit intomasterfrom
Conversation
The factional part of the date/time seconds was being parsed and converted to an integer in order to pass to the milliseconds parameter. However, if there were more than 3 digits, then this would be more than a thousand and spill over into the seconds (and possible minutes). Moreover, if the fractional part started with a zero, this would get lost in the conversion to an integer. This commit fixes the parsing and truncates the value to max 3 digits (milliseconds is the finest resolution supported). Signed-off-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
andrew-coleman
force-pushed
the
millis_fix
branch
from
3413155 to
097900d
Compare
mattbaileyuk
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The factional part of the date/time seconds was being parsed and converted to an integer in order to pass to the milliseconds parameter. However, if there were more than 3 digits, then this would be more than a thousand and spill over into the seconds (and possible minutes).
Moreover, if the fractional part started with a zero, this would get lost in the conversion to an integer. This commit fixes the parsing and truncates the value to max 3 digits (milliseconds is the finest resolution supported).
resolves #778