DotNet2019Challenge - intentando mejorar el rendimiento#3
Open
mhernanrobledo wants to merge 15 commits intojsuarezruiz:masterfrom
Open
DotNet2019Challenge - intentando mejorar el rendimiento#3mhernanrobledo wants to merge 15 commits intojsuarezruiz:masterfrom
mhernanrobledo wants to merge 15 commits intojsuarezruiz:masterfrom
Conversation
…rvice CustomNavigationView
Owner
|
Muchas gracias por participar!.
Enhorabuena has añadido más de 3 mejoras que impactan en el rendimiento. Ya hay una PR previa que también cumple los requisitos. En caso de no querer la entrada, por orden pasaría a ti. En cualquier caso, espero que te haya resultado divertido y que nos veamos en la DotNet 2019. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hola quería participar en el reto para seguir practicando con Xamarin. Solamente he utilizado el emulador de Android y en el dispositivo físico Android.
Los cambios que he introducido son:
Upgradde Android from 27.0.2.1 to 28.0.0.1
Upgradde Xamarin.Forms 2.5.1.527436 to latest preview 4.0.0.346134-pre9
Upgradde Xamarin.FFImageLoading.Forms 2.4.4.859 a latest stable 2.4.5.922
Actualicé la versión de Android target a la 9.0
Añadí los flags: global::Xamarin.Forms.Forms.SetFlags("Shell_Experimental", "Visual_Experimental", "CollectionView_Experimental", "FastRenderers_Experimental");
Añadí el Inversion of Control Container de Autofac en el patrón MVVM añadiendo sus correspondientes ViewModelLocator, ViewModelBase, NavigationServices
Cambie los controles Image por ffimageloading:CachedImage usando cache
En MoviesView reemplace controls:HorizontalList por CollectionViews ya que usa automáticamente la virtualización.
Añadi glidex.forms al Android Project.
Use el MoviesService que hizo MookieFumi para utilizar streams. (gracias por la ayuda)
Cambie las vistas para utilizar Compiled Bindings usando [XamlCompilation(XamlCompilationOptions.Compile)]
Añadí un a pantalla de inicio SplashScreen para distraer la atención mientras se carga la app.