Add thin_shrink and era_repair to Makefile and create manpages#325
Draft
regulad wants to merge 2 commits intojthornber:mainfrom
Draft
Add thin_shrink and era_repair to Makefile and create manpages#325regulad wants to merge 2 commits intojthornber:mainfrom
thin_shrink and era_repair to Makefile and create manpages#325regulad wants to merge 2 commits intojthornber:mainfrom
Conversation
Author
|
With the help of an LLM (Moonshot Kimi 2.5) and some good old-fashioned legwork, I've fashioned a "provisional" set of manpages. Obviously, they need to be manually reviewed by a maintainer more familiar with the quirks than I. |
Author
|
There are still some issues with the instructions. |
Collaborator
|
I'll read through it later. I think you could separate the era_repair and thin_shrink man pages into different commits. Also, there was already a pending pull request suggesting similar Makefile changes, so I would cherry-picking the commit first. I noticed the TOOLS list was reordered. Is there a functional reason for this change, or is it just for readability? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes have been introduced in this PR:
thin_shrinkandera_repairTOOLSarray in Makefile, updating it to matchsrc/bin/pdata_tools.rsexactly withthin_shrinkandera_repair.TOOLSandMANPAGESto create symlinks and manpages repsectively.thin_*manpages with a "SEE ALSO" section to mentionthin_shrink.This pull request has been created as a draft, as I do not have enough knowledge of the semantics of
era_repairto populate theSYNOPSIS,DESCRIPTION, andEXAMPLESsections in the manpage.I am slightly more familiar with
thin_shrinksince I have used it in my deployments; however, my knowledge is not comprehensive enough to write a manpage.Help is requested from the maintainers @jthornber and @mingnus for the manpages
era_repairandthin_shrinkrepsectively.Thank you for the creation of this project, it has served exceptionally useful in my deployments.