Skip to content

fix: align logs, theme bootstrap, and AI image validation#605

Merged
jtn0123 merged 7 commits into
mainfrom
codex/fix-logs-theme-ai-playlist
Apr 28, 2026
Merged

fix: align logs, theme bootstrap, and AI image validation#605
jtn0123 merged 7 commits into
mainfrom
codex/fix-logs-theme-ai-playlist

Conversation

@jtn0123
Copy link
Copy Markdown
Owner

@jtn0123 jtn0123 commented Apr 28, 2026

Summary

  • Suppress expected Waitress SSE disconnect noise for dashboard/progress streams.
  • Align JSON, dev-buffer, and journal log timestamps with the configured device timezone, including after Settings saves.
  • Apply persisted theme/tweak settings before CSS loads to prevent alternate-theme flash.
  • Validate AI Image provider keys before random prompt generation and playlist scheduling.

Base Branch Confirmation

  • This PR is based on origin/main (not a stale long-lived branch)
  • I rebased/merged latest origin/main before opening

Parent-Fork Sync Checklist

  • If this PR syncs from fatihak/InkyPi, changes were cherry-picked by feature (N/A)
  • Relevant upstream behavior differences were documented in PR description (N/A)
  • Plugin/add-to-playlist/update flows were smoke-tested after sync (N/A; AI Image playlist flow covered by tests)

Compatibility/Release Checklist

  • pytest relevant suites pass locally
  • No breaking API route/path changes
  • Error responses follow JSON contract (success:false,error,code,details,request_id)
  • Docs updated for new flags/endpoints/UI (N/A)
  • Frontend changes (src/static/**, src/templates/**): ran browser tests (REQUIRE_BROWSER_SMOKE=1 python3 -m pytest tests/integration/test_browser_smoke.py -q) and all passed

Testing

  • PYTHONPATH=src python3 -m pytest -q tests/test_json_logging.py tests/test_log_redaction.py tests/static/test_theme_bootstrap.py tests/unit/test_playlist_workflows.py tests/plugins/test_ai_image.py::test_ai_image_random_prompt_endpoint_openai tests/plugins/test_ai_image.py::test_ai_image_random_prompt_endpoint_missing_key tests/integration/test_time_freeze.py
  • PYTHONPATH=src python3 -m pytest -q tests/unit/test_settings_save.py::TestSaveSettings::test_save_settings_reconfigures_log_timezone tests/test_json_logging.py tests/test_log_redaction.py tests/static/test_theme_bootstrap.py tests/unit/test_playlist_workflows.py tests/plugins/test_ai_image.py::test_ai_image_random_prompt_endpoint_openai tests/plugins/test_ai_image.py::test_ai_image_random_prompt_endpoint_missing_key tests/integration/test_time_freeze.py
  • PYTHONPATH=src python3 -m pytest -q tests/smoke/test_route_smoke.py tests/unit/test_smoke_render.py tests/integration/test_plugin_preview_smoke.py
  • PYTHONPATH=src REQUIRE_BROWSER_SMOKE=1 python3 -m pytest -q tests/integration/test_browser_smoke.py
  • python3 -m ruff check src/app_setup/logging_setup.py src/utils/logging_utils.py src/inkypi.py src/blueprints/settings/_config.py src/blueprints/settings/__init__.py src/services/playlist_workflows.py tests/test_json_logging.py tests/test_log_redaction.py tests/integration/test_time_freeze.py tests/unit/test_playlist_workflows.py tests/static/test_theme_bootstrap.py
  • git diff --check

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@jtn0123 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 40 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 53e7132d-5a42-49f1-b9ed-dce2954c9691

📥 Commits

Reviewing files that changed from the base of the PR and between 6c3a318 and 2927cd2.

📒 Files selected for processing (24)
  • .github/workflows/memory-diff.yml
  • pytest.ini
  • scripts/format_memory_diff.py
  • scripts/memory_diff.py
  • src/app_setup/logging_setup.py
  • src/blueprints/settings/__init__.py
  • src/blueprints/settings/_config.py
  • src/inkypi.py
  • src/services/playlist_workflows.py
  • src/static/scripts/plugin_schema.js
  • src/templates/base.html
  • src/templates/plugin.html
  • src/utils/logging_utils.py
  • tests/integration/test_time_freeze.py
  • tests/static/test_js_api_contracts.py
  • tests/static/test_theme_bootstrap.py
  • tests/test_json_logging.py
  • tests/test_log_redaction.py
  • tests/unit/test_install_scripts.py
  • tests/unit/test_memory_diff_format.py
  • tests/unit/test_playlist_workflows.py
  • tests/unit/test_settings_logs.py
  • tests/unit/test_settings_save.py
  • tests/unit/test_template_snapshots.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-logs-theme-ai-playlist

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

Memory diff vs base

Metric Base PR Delta
Peak RSS 61.41 MB 61.48 MB +76.0 KB
sys.modules count 592 592 0

Largest grouped allocator deltas

Group Base PR Delta
werkzeug 227.2 KB 2.24 MB +2.01 MB
python stdlib 2.56 MB 1.51 MB -1.05 MB
attr 229.8 KB 1.23 MB +1.00 MB
lark 11.77 MB 12.77 MB +1015.9 KB
arrow 1.10 MB 132.5 KB -993.3 KB
python import system 14.32 MB 14.63 MB +317.4 KB
Source-location detail: top 20 deltas (sampled base=500, PR=500)
# Location Base PR Delta
1 parsers/lalr_parser_state.py:105 4.00 MB 0 B -4.00 MB
2 <frozen importlib._bootstrap>:488 5.63 MB 7.93 MB +2.30 MB
3 python3.12/ast.py:52 2.00 MB 0 B -2.00 MB
4 lark/tree.py:67 0 B 2.00 MB +2.00 MB
5 lark/tree.py:145 0 B 2.00 MB +2.00 MB
6 <frozen importlib._bootstrap_external>:757 7.56 MB 6.46 MB -1.10 MB
7 python3.12/ast.py:86 0 B 1.00 MB +1.00 MB
8 lark/visitors.py:180 2.00 MB 1.00 MB -1.00 MB
9 lark/lexer.py:210 1.00 MB 0 B -1.00 MB
10 parsers/lalr_analysis.py:285 1.00 MB 0 B -1.00 MB
11 <frozen importlib._bootstrap>:443 1.00 MB 0 B -1.00 MB
12 lark/load_grammar.py:914 1.00 MB 0 B -1.00 MB
13 arrow/locales.py:3873 1.00 MB 0 B -1.00 MB
14 lark/tree.py:147 0 B 1.00 MB +1.00 MB
15 attr/validators.py:236 0 B 1.00 MB +1.00 MB
16 sansio/response.py:247 0 B 1.00 MB +1.00 MB
17 lark/load_grammar.py:592 0 B 1.00 MB +1.00 MB
18 lark/tree.py:146 0 B 1.00 MB +1.00 MB
19 lark/visitors.py:122 0 B 1.00 MB +1.00 MB
20 werkzeug/http.py:43 0 B 1.00 MB +1.00 MB

JTN-610 · backend=base:memray, pr:memray · informational only, does not block merge. Hard RSS budgets are enforced separately by JTN-608. Source-location rows are sampled allocator attribution, not exact module ownership.

@sonarqubecloud
Copy link
Copy Markdown

@jtn0123 jtn0123 merged commit 81362c9 into main Apr 28, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant