Skip to content

ci: harden benchmark and mutation gates#606

Merged
jtn0123 merged 1 commit into
mainfrom
codex/harden-quality-gates
Apr 28, 2026
Merged

ci: harden benchmark and mutation gates#606
jtn0123 merged 1 commit into
mainfrom
codex/harden-quality-gates

Conversation

@jtn0123
Copy link
Copy Markdown
Owner

@jtn0123 jtn0123 commented Apr 28, 2026

Summary

  • Fix the narrow mutation harness targets after refresh_task moved into package modules.
  • Make benchmark cache-miss fallback blocking against the committed repo baseline so PR regressions are not silently advisory.
  • Upload benchmark JSON, effective baseline, and comparison logs as benchmark-results artifacts for PR debugging.
  • Document the benchmark and narrow mutation gate behavior.

Test plan

  • PYTHONPATH=src pytest -q tests/unit/test_quality_gates.py tests/test_mutmut_config.py
  • PYTHONPATH=src python3 scripts/mutation_check.py
  • python3 -m py_compile scripts/mutation_check.py scripts/benchmark_compare.py
  • Workflow YAML parse with yaml.safe_load
  • bash scripts/lint.sh

Benchmark note

  • Local benchmark tests passed on macOS, but comparing local timings to the committed repo baseline showed expected cross-machine noise on render benchmarks. The CI gate is the source of truth because it runs on the consistent GitHub Actions environment and uses the cached per-OS baseline when present.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@jtn0123 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 28 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 601f975e-a474-4f84-a264-0e6655547723

📥 Commits

Reviewing files that changed from the base of the PR and between 90eaffb and 7570854.

📒 Files selected for processing (5)
  • .github/workflows/ci.yml
  • docs/benchmarking.md
  • docs/mutation_testing.md
  • scripts/mutation_check.py
  • tests/unit/test_quality_gates.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/harden-quality-gates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Memory diff vs base

Metric Base PR Delta
Peak RSS 29.29 MB 29.20 MB -84.0 KB
sys.modules count 592 592 0
Top 20 startup allocators
# Location Base PR Delta
1 parsers/lalr_parser_state.py:105 5.00 MB 0 B -5.00 MB ⚠️
2 <frozen importlib._bootstrap_external>:757 8.56 MB 5.46 MB -3.10 MB ⚠️
3 <frozen importlib._bootstrap>:488 5.63 MB 7.93 MB +2.30 MB ⚠️
4 lark/visitors.py:180 1.00 MB 3.00 MB +2.00 MB ⚠️
5 lark/tree.py:147 0 B 2.00 MB +2.00 MB ⚠️
6 python3.12/ast.py:78 0 B 1.00 MB +1.00 MB ⚠️
7 lark/visitors.py:284 1.00 MB 0 B -1.00 MB ⚠️
8 lark/lexer.py:215 2.00 MB 1.00 MB -1.00 MB ⚠️
9 python3.12/ast.py:52 1.00 MB 0 B -1.00 MB ⚠️
10 lark/lexer.py:43 1.00 MB 0 B -1.00 MB ⚠️
11 parsers/lalr_analysis.py:299 1.00 MB 0 B -1.00 MB ⚠️
12 lark/tree.py:145 1.00 MB 0 B -1.00 MB ⚠️
13 <string>:1 1.00 MB 0 B -1.00 MB ⚠️
14 arrow/locales.py:3163 1.00 MB 0 B -1.00 MB ⚠️
15 lark/lexer.py:304 0 B 1.00 MB +1.00 MB ⚠️
16 attr/validators.py:236 0 B 1.00 MB +1.00 MB ⚠️
17 lark/visitors.py:120 0 B 1.00 MB +1.00 MB ⚠️
18 parsers/lalr_analysis.py:137 0 B 1.00 MB +1.00 MB ⚠️
19 werkzeug/http.py:43 0 B 1.00 MB +1.00 MB ⚠️
20 sansio/response.py:189 0 B 1.00 MB +1.00 MB ⚠️

JTN-610 · backend=base:memray, pr:memray · informational only, does not block merge. Hard RSS budgets are enforced separately by JTN-608.

@sonarqubecloud
Copy link
Copy Markdown

@jtn0123 jtn0123 merged commit 645218c into main Apr 28, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant