Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent-binary): simplestream finder in stub #19500

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ycliuhw
Copy link
Member

@ycliuhw ycliuhw commented Apr 11, 2025

This PR is implement a new function on the stubdomain service that allows the caller to get the models BootStrapEnviron. We have avoid leaking out the provider for a model out of the domain services now. Because we are in a time crunch we are going to allow it to be fetched via a domain service so that it can be supplied to the ToolsFinder facade. This is needed so we can feed this into environ tools for fetching agent binaries.

Checklist

  • Code style: imports ordered, good names, simple structure, etc
  • Comments saying why design decisions were made
  • Go unit tests, with comments saying what you're testing
  • Integration tests, with comments saying what you're testing
  • doc.go added or updated in changed packages

QA steps

TODO

Documentation changes

No

Links

Jira card:

@jujubot jujubot added the 4.0 label Apr 11, 2025
@ycliuhw ycliuhw marked this pull request as draft April 11, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants