-
Couldn't load subscription status.
- Fork 31
Allow using statements to access packages loaded within workspace
#103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@davidanthoff could you have a look at this (and this on the LS side) now. Alongside whats described in first comment above there are some fixes for reference resolving (that were less apparent prior to this change). |
|
@ZacLN what is the next step here? Probably for you to clean up merge conflicts, and then I review it? |
|
Should be good to merge now, lets see what the tests say. |
|
So main question is whether we try to put this in before Juliacon, or after? My sense is maybe after? |
|
@ZacLN so I tried to fix this, there were some typos, but now I'm stuck :) |
|
Tests should pass now. Would still be good if Zac can approve the PR though :) |
|
Yes looks good ( |
I think this is all that's needed on this side so that
usingstatements will point to the 'live' code of packages that is being edited. Alongside the symbolserver store of packages I've added a newworkspacepackagesfield which will be checked prior to the symbolserver list. It will be up to the user (e.g. the LanguageServerInstance) to ensure that this list is properly managed, I'll open a PR on the other side to discuss how this is managed.Todo:
Example code: