Skip to content

Add initial Mini Vibeathon competition domain#25

Open
julianromli wants to merge 3 commits into
ntfd/competition-technical-doc-6044from
ntfd/mini-vibeathon-core-7169
Open

Add initial Mini Vibeathon competition domain#25
julianromli wants to merge 3 commits into
ntfd/competition-technical-doc-6044from
ntfd/mini-vibeathon-core-7169

Conversation

@julianromli

@julianromli julianromli commented May 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • add the initial competition schema, seed data, and shared competition types
  • implement the first public competition routes, feed/detail components, and submit flow scaffolding
  • extend the unified comments system and admin comment mapping for competition entries
  • add a basic admin competitions board entry point and sitemap updates

Verification

  • npx @biomejs/biome check on the changed competition/comment files
  • attempted npx --package typescript tsc --noEmit but the cloud image does not have the workspace dependencies installed, so the run is blocked by repo-wide missing-module errors before it can validate this slice
Open in Web Open in Cursor 

Co-authored-by: faizntfd <faizintfd@gmail.com>
@vercel

vercel Bot commented May 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vibedevid Error Error May 9, 2026 4:43am

@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f8eecdf1-8a4b-4aa3-87e9-4c03ea484e16

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ntfd/mini-vibeathon-core-7169

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: faizntfd <faizintfd@gmail.com>
@julianromli
julianromli marked this pull request as ready for review May 8, 2026 01:04
@julianromli

Copy link
Copy Markdown
Owner Author

@cubic-dev-ai

@cubic-dev-ai

cubic-dev-ai Bot commented May 8, 2026

Copy link
Copy Markdown

@cubic-dev-ai

@julianromli I have started the AI code review. It will take a few minutes to complete.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd838879ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +192 to +194
const projectMap = new Map<string, string>(
(projectsResult.data || []).map((p: { id: string; title: string }) => [p.id, p.title]),
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve numeric project IDs in report title lookup

Project reports can now render as Unknown Project because this map stores raw projects.id values (typically numbers from Supabase for integer columns) but later lookups use entityInfo.entityId as a string. In JavaScript Map, numeric key 1 and string key '1' are different, so project titles are missed whenever a reported comment belongs to a project.

Useful? React with 👍 / 👎.

Comment on lines +213 to +215
.eq('status', 'active')
.order('starts_at', { ascending: false })
.limit(1)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Constrain active competition selection to the live date window

This query picks the most recent row with status = 'active' but does not enforce starts_at <= now < ends_at. If multiple competitions are marked active (or one is left active after ending), pages that rely on getActiveCompetition() can bind to the wrong competition, causing submission/vote flows to point at a closed or not-yet-open event.

Useful? React with 👍 / 👎.

Co-authored-by: faizntfd <faizintfd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants