Add error-prone.picnic.tech/bugpatterns/NonStaticImport

[Pankraz76]

Add error-prone.picnic.tech/bugpatterns/NonStaticImport

• https://error-prone.picnic.tech/bugpatterns/NonStaticImport

related to:

• [prone] fix UnnecessarilyFullyQualified #5189
• [prone] remove disable warning leftovers to finalize convention principle #5190
• [prone] fix warning StaticImport, NonStaticImport diffplug/spotless#2743
• Add org.junit.openrewrite.SanityCheck #5193

---

I hereby agree to the terms of the JUnit Contributor License Agreement.

---

Definition of Done

• There are no TODOs left in the code
• Method preconditions are checked and documented in the method's Javadoc
• Coding conventions (e.g. for logging) have been followed
• Change is covered by automated tests including corner cases, errors, and exception handling
• Public API has Javadoc and @API annotations
• Change is documented in the User Guide and Release Notes

[Pankraz76]

kindly asking, if this is any good?

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: 27418df
▶️ Tests: 55426 executed
⚪️ Checks: 16/16 completed

---

Learn more about TestLens at testlens.app.

[rickie]

Apart from the changes in the gradle file, they changes LGTM!

[marcphilipp]

We explicitly decided against using NonStaticImport hence it's in the list of disabled rules.

[Pankraz76]

yes this recipe is quite questionable therefore disabled in gradle as well. But the counterpart is quite impressive.

Is this something to reconsider, please?

• [picnic] add EmptyMethod #34881 #34905 #35863 gradle/gradle#35878

[marcphilipp]

To me, deciding whether to use a static import is a stylistic choice with pros and cons that can be weighed as part of PR reviews. I'd rather focus on ErrorProne rules that can help prevent actual bugs.

[Pankraz76]

yes but having easy code access helps to read the code better to then prevent or quicker fix some issues or create new (features or course).

[Pankraz76]

of course i dont demand any style but for me its overwelaming to read and avoid all the nonsens overhead i dont need and want to conider when dealing with the bare business logic.

• https://github.com/junit-team/junit-framework/pull/5223/changes#r2616250147