-
Notifications
You must be signed in to change notification settings - Fork 7
Fix agent errors #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix agent errors #24
Conversation
2816c9f to
68809d3
Compare
|
Rebased onto latest |
@3coins The commits are the same as what had existed before, minus the first 2 commits that were merged in #21; the only merge conflicts I addressed were minor whitespace issues, no code changes. I was debugging this and found that after restarting JupyterLab, the notebook now contains an input cell that was added by Jupyternaut in the previous session. So Jupyternaut did add the cell correctly, I just needed to rebuild
However, the agent is getting stuck on the same error when trying to run the cell that was created ( |
|
Interestingly, if I re-open the notebook and ask Jupyternaut in a new chat to run all the cells, Jupyternaut can do that. Seems like the user's awareness state does not always contain the |
|
@3coins I see the problem. This also explains the weird behavior I recorded above. There are two separate tools: |
efcf4a4 to
6133149
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3coins Thank you for working so hard on this over Thanksgiving week! The new agent is much better than before, and the real-time navigation capabilities are really impressive. I pushed a commit to add jupyterlab_notebook_awareness as a dependency so this works out of the box for users.
I noticed a couple of issues, but I think we can iterate on these as follow-up items & merge this for now.
Follow-up issues:
| #await write_to_cell_collaboratively(ydoc, ycell, content) | ||
| ycell["source"] = content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be causing #26. Updating ydoc._cells[cell_index]["source"] may not cause a YDoc update to be broadcasted immediately.


Summary
This PR refactors the Jupyternaut agent implementation to improve reliability, performance, and user experience.
Key Improvements: