Fix when base_url is used in combination with a gateway client #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1549 .
I am operating under the assumption that the preferred order of operations for the url paths should be:
JUPYTER_GATEWAY_KERNELSPECS_ENDPOINT/JUPYTER_GATEWAY_KERNELS_ENDPOINTbase_urlto extend the paths when provided/api/kernelspecsas a last resortThis was the only way I could figure out how to fix the issue. The challenge as I see it is the combination of the order of operations above and the widespread usage of
gateway_client.GatewayClientthroughout the project. If there is some other way thatbase_urlcan get contextualized intogateway_client(I am not an expert in the codebase), I think that would be preferable to the approach I ended up taking.