Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the debugger not starting #632

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

JohanMabille
Copy link
Member

No description provided.

@@ -322,7 +322,7 @@ namespace xpyt
std::string controller_header_end_point = xeus::get_controller_end_point("debugger_header");
std::string publisher_end_point = xeus::get_publisher_end_point();

bind_sockets(controller_end_point, controller_header_end_point);
bind_sockets(controller_header_end_point, controller_end_point);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anutosh491 for catching this!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Contributor

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@JohanMabille JohanMabille merged commit 1bb6d4c into jupyter-xeus:main Jun 21, 2024
13 checks passed
@JohanMabille JohanMabille deleted the debugger_fix branch June 21, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants