Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👶 steps for comms #94

Merged
merged 9 commits into from
Sep 10, 2024
Merged

👶 steps for comms #94

merged 9 commits into from
Sep 10, 2024

Conversation

romainfrancois
Copy link
Contributor

related to #43

  • Adds xeusr_comm_register_target and xeusr_comm_unregister_target for now.
  • Needs comm_open(), comm_close() ...

romainfrancois
romainfrancois commented Aug 29, 2024
View reviewed changes
src/routines.cpp Outdated Show resolved Hide resolved
romainfrancois
romainfrancois commented Aug 29, 2024
View reviewed changes
src/routines.cpp Outdated Show resolved Hide resolved
@romainfrancois romainfrancois marked this pull request as ready for review September 10, 2024 07:35
@romainfrancois romainfrancois merged commit 5a87799 into main Sep 10, 2024
2 of 3 checks passed
@romainfrancois romainfrancois deleted the comm branch September 10, 2024 07:35
@SylvainCorlay
Copy link
Member

It seems that this PR broke the windows build.

@SylvainCorlay
Copy link
Member

C:\Users\runneradmin\micromamba-root\envs\xeus-r\Lib\R\include\R_ext/Complex.h(81): error C3646: 'private_data_c': unknown override specifier

@romainfrancois
Copy link
Contributor Author

That's odd. I haven't touched Complex.h things. I'll have a look.

@anutosh491
Copy link
Contributor

I attempted to fix the windows build and have written my logic here (#100 (comment)). The build & tests pass as expected.

cc @SylvainCorlay @romainfrancois

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romainfrancois @SylvainCorlay @anutosh491