Skip to content

Commit

Permalink
Small improvement for reading package.json
Browse files Browse the repository at this point in the history
  • Loading branch information
fcollonval committed Dec 28, 2020
1 parent ed1dde6 commit d3010c6
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 6 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Install Python
uses: actions/setup-python@v2
with:
python-version: '3.7'
python-version: '3.9'
architecture: 'x64'
- name: Install dependencies
run: python -m pip install jupyterlab~=3.0
Expand All @@ -28,6 +28,7 @@ jobs:
jlpm
jlpm run eslint:check
python -m pip install .
jupyter labextension disable @jupyterlab/launcher-extension
jupyter labextension list 2>&1 | grep -ie "@jlab-enhanced/launcher.*OK"
python -m jupyterlab.browser_check
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jupyter labextension disable @jupyterlab/launcher-extension
or

```bash
conda install jlab-enhanced-launcher
conda install -c conda-forge jlab-enhanced-launcher
jupyter labextension disable @jupyterlab/launcher-extension
```

Expand All @@ -36,7 +36,7 @@ jupyter labextension enable @jupyterlab/launcher-extension
or

```bash
conda remove jlab-enhanced-launcher
conda remove -c conda-forge jlab-enhanced-launcher
jupyter labextension enable @jupyterlab/launcher-extension
```

Expand Down
2 changes: 2 additions & 0 deletions binder/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ dependencies:
- nodejs >=14,<15
- pip
- wheel
# Dependencies
- packaging
# Fix binder
- parso >=0.8.0,<0.9.0
- jupyter_telemetry >=0.1.0
2 changes: 1 addition & 1 deletion jlab_enhanced_launcher/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from ._version import __version__

HERE = pathlib.Path(__file__).parent.absolute()
HERE = pathlib.Path(__file__).parent.resolve()

with (HERE / 'labextension' / 'package.json').open() as fid:
data = json.load(fid)
Expand Down
2 changes: 1 addition & 1 deletion jlab_enhanced_launcher/_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ def _fetchVersion():
import pathlib
from packaging.version import parse

HERE = pathlib.Path(__file__).parent.absolute()
HERE = pathlib.Path(__file__).parent.resolve()

for d in HERE.rglob('package.json'):
try:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@jlab-enhanced/launcher",
"version": "3.0.0",
"version": "3.0.1",
"description": "A enhanced launcher for JupyterLab",
"keywords": [
"jupyter",
Expand Down

0 comments on commit d3010c6

Please sign in to comment.