Repository navigation
Support importing local .json files in ImportResolver (#288) - #291
Open
Yash990-bit wants to merge 1 commit into
Open
Yash990-bit wants to merge 1 commit into
Yash990-bit wants to merge 1 commit into
Conversation
Contributor
|
Preview environments for this pull request:
|
Author
|
Hi @Darshan808 when you get chance please review these |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #288.
This PR adds support for importing local
.jsonfiles in Plugin Playground'sImportResolver.Problem
Previously:
_localImportCandidatesonly probed.ts,.tsx,.js,.css, and theirindex.*variants. Importing without explicit.jsonextension failed resolution._resolveLocalFileonly handled.cssand.svg. Any.jsonfile fell through todynamicLoaderwhich treated it as TypeScript code, leading to transpile or runtime evaluation errors.Solution
.jsonandindex.jsonto_localImportCandidatesinsrc/resolver.ts._loadLocalJsoninImportResolverto parse JSON and export bothdefaultand named properties (consistent with wheel asset module loading insrc/wheel.ts).ui-tests/tests/plugin-playground.spec.tstesting default and named imports from local JSON files.