Localize user facing strings #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brichet
reviewed
Dec 1, 2025
Collaborator
There was a problem hiding this comment.
Thanks @jtpio, this looks great!
I have some nitpick comments below.
I also wonder if we want to add the translator to the chat model in this PR too. There are also some displayed text related to message error or tool calls.
Co-authored-by: Nicolas Brichet <[email protected]>
Collaborator
@jtpio do you think that we should do it in a follow up PR ? |
Member
Author
|
Maybe we could indeed track it separately? Thinking that the tool call user facing strings may need to be revisited too (for example as part of #160) |
brichet
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12