Skip to content

Comments

fix(rollout): favor newest session mtime#365

Merged
zemaj merged 2 commits intomainfrom
fix/resume-last-mtime
Oct 29, 2025
Merged

fix(rollout): favor newest session mtime#365
zemaj merged 2 commits intomainfrom
fix/resume-last-mtime

Conversation

@zemaj
Copy link

@zemaj zemaj commented Oct 28, 2025

Summary

  • sort rollout listings by filesystem modified time before filename timestamp/uuid
  • persist the formatted mtime as modified_at on conversation items for consumers
  • add regression coverage ensuring resume --last selects the freshest modified session

Testing

  • ./build-fast.sh

Fixes #306

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -194,9 +208,6 @@ async fn traverse_directories_for_paths(
continue;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update cursor logic to include modification time ordering

The listing now orders candidates by (modified, ts, uuid) (see the new sort above), but the pagination cursor still records only the filename timestamp and UUID and this comparison continues to skip entries solely on ts/sid. If the newest modified time belongs to an older timestamp (e.g., an old session file touched recently), get_conversations(page_size=1) will return that file first, and on the next call every session whose timestamp is later than the cursor is filtered out here and never surfaces. This breaks next_cursor pagination whenever filesystem mtimes reorder sessions beyond their filename timestamps. The cursor and skip logic need to include the modification time to maintain a stable order.

Useful? React with 👍 / 👎.

@zemaj
Copy link
Author

zemaj commented Oct 28, 2025

Preview Build rerun triggered after #364 merged; watching for green checks.

@zemaj
Copy link
Author

zemaj commented Oct 28, 2025

Fresh Preview Build queued with updated toolchain after #364 merged; watching for green checks.

@zemaj
Copy link
Author

zemaj commented Oct 28, 2025

Preview Build rerun queued with Rust 1.90.0 plus MUSL targets after #370 merged. Tracking run: https://github.com/just-every/code/actions/runs/18870466957

@zemaj zemaj force-pushed the main branch 2 times, most recently from 804b5ad to b7927a2 Compare October 28, 2025 23:57
@zemaj zemaj merged commit 5415e90 into main Oct 29, 2025
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coder resume --last does not really restore the last session

1 participant