Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -194,9 +208,6 @@ async fn traverse_directories_for_paths( | |||
| continue; | |||
There was a problem hiding this comment.
Update cursor logic to include modification time ordering
The listing now orders candidates by (modified, ts, uuid) (see the new sort above), but the pagination cursor still records only the filename timestamp and UUID and this comparison continues to skip entries solely on ts/sid. If the newest modified time belongs to an older timestamp (e.g., an old session file touched recently), get_conversations(page_size=1) will return that file first, and on the next call every session whose timestamp is later than the cursor is filtered out here and never surfaces. This breaks next_cursor pagination whenever filesystem mtimes reorder sessions beyond their filename timestamps. The cursor and skip logic need to include the modification time to maintain a stable order.
Useful? React with 👍 / 👎.
|
Preview Build rerun triggered after #364 merged; watching for green checks. |
|
Fresh Preview Build queued with updated toolchain after #364 merged; watching for green checks. |
|
Preview Build rerun queued with Rust 1.90.0 plus MUSL targets after #370 merged. Tracking run: https://github.com/just-every/code/actions/runs/18870466957 |
804b5ad to
b7927a2
Compare
Summary
modified_aton conversation items for consumersresume --lastselects the freshest modified sessionTesting
Fixes #306