fix(core/auth): bootstrap code home on first run (#5969)#384
Closed
fix(core/auth): bootstrap code home on first run (#5969)#384
Conversation
zemaj
commented
Nov 6, 2025
Author
zemaj
left a comment
There was a problem hiding this comment.
Pulled the branch and validated the first-run bootstrap locally:
- Called
std::fs::create_dir_allunconditionally insidewrite_auth_jsonso concurrent boots and pre-existing directories remain safe without TOCTOU checks. - Added cross-platform coverage: macOS-style paths with spaces, Windows backslash paths (cfg gated), read-only file rewrites, and unix permission failures to prove the new bootstrap behaves as expected.
- Confirmed the missing
auth.jsonpath now returnsOk(None)cleanly (first-run CLI flow works) and the new tests capture regressions.
Tests:
cargo test -p code-core login_with_api_key_handles_paths_with_spacescargo test -p code-core write_auth_json_fails_when_file_is_readonlycargo test -p code-core write_auth_json_propagates_permission_denied_unix./build-fast.sh
Remaining risk: Windows ACL tightening is still inherited from the parent directory; follow-up hardening may be needed if stricter isolation is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth.jsonso Windows reinstalls don’t fail on missing parentsauth.jsonas "no auth yet" instead of an error, allowing first-run bootstrap to continueload_auth, and CLI API-key loginTesting
Closes openai#5969.