Skip to content

Commit

Permalink
CPD-1653: Fixed output logger file location and added logger to the d… (
Browse files Browse the repository at this point in the history
#117)

* CPD-1653: Fixed output logger file location and added logger to the default gulp tasks.

* CPD-1653: Fixed unit tests.

* CPD-1653: Updated gulp logger:create doc.

* CPD-1653: Bumped changelog date up.
  • Loading branch information
kevinrodrigues authored and ashleynolan committed Mar 8, 2018
1 parent 07f4ee9 commit e3e3c5d
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 8 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

v7.13.0
------------------------------
*March 8, 2018*

### Changed
- Default gulp tasks so that the logger file is created when gulp is run.
- Updated the pathBuilder `jsErrorLoggerDir` property to `assetDistDir` so it outputs in the correct directory.
- Updated `pathBuilder` unit tests.

v7.12.0
------------------------------
*February 16, 2018*
Expand Down
7 changes: 2 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,9 @@ Runs the following tasks
- Add hashed version to file name
- Output bundle to the dist directory

### `logger-file`
### `logger:createFile`

Runs the following tasks

- #### `logger-file:logger-file-create`
Add the server-side file required for the errorLogger to be inserted into the filesystem.
Adds the server-side file required for the errorLogger to be inserted into the filesystem.

### `images`

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@justeat/gulp-build-fozzie",
"version": "7.12.0",
"version": "7.13.0",
"description": "Gulp build tasks for use across Fozzie modules",
"main": "index.js",
"author": "Damian Mullins <[email protected]> (http://www.damianmullins.com)",
Expand Down
2 changes: 1 addition & 1 deletion pathBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const buildPaths = config => {
jsSrcDir: `${config.assetSrcDir}/${config.js.jsDir}`,
jsDistDir: `${config.assetDistDir}/${config.js.jsDir}`,

jsErrorLoggerDir: `${config.webRootDir}/${config.logger.dir}`,
jsErrorLoggerDir: `${config.assetDistDir}/${config.logger.dir}`,

imgSrcDir: `${config.assetSrcDir}/${config.img.imgDir}`,
imgDistDir: `${config.assetDistDir}/${config.img.imgDir}`,
Expand Down
1 change: 1 addition & 0 deletions tasks/default.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ gulp.task('default', callback => {
runSequence(
['copy:fonts', 'images'],
['css', 'scripts'],
['logger:createFile'],
...config.sw.isEnabled ? ['service-worker'] : [],
callback
);
Expand Down
2 changes: 1 addition & 1 deletion test/pathBuilder.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ describe('javascript paths', () => {

describe('`logger` path', () => {
it('`jsErrorLoggerSubDir` path should be correct', () => {
expect(pathBuilder.jsErrorLoggerDir).toBe('./js/shared');
expect(pathBuilder.jsErrorLoggerDir).toBe('dist/js/shared');
});
});

Expand Down

0 comments on commit e3e3c5d

Please sign in to comment.